Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use merged deps config by default, optionally specify --no-merge-config #14

Closed
wants to merge 1 commit into from
Closed

use merged deps config by default, optionally specify --no-merge-config #14

wants to merge 1 commit into from

Conversation

xfthhxk
Copy link
Contributor

@xfthhxk xfthhxk commented Oct 2, 2018

This is to address #7 and #13.

  • By default, uses deps reader to merge deps.edn files.
    • This obviates the need to specify :mvn/repos in the project's deps.edn
      • Without a :mvn/repos entry users see an exception, for example:
Exception in thread "main" org.eclipse.aether.resolution.ArtifactDescriptorException: Failed to read artifact descriptor for org.apache.httpcomponents:httpcore:jar:4.4.9
    at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:323)
...
    at clojure.tools.deps.alpha$resolve_deps.invoke(alpha.clj:197)
    at cambada.uberjar$get_dep_jars.invokeStatic(uberjar.clj:109)
  • Also obviates the need to assoc default clojure dependency and :paths entry.
  • Adds an optional --no-merge-config cli parameter to only use the specified deps file.

These changes should help lein users more easily migrate to tools.deps based workflow.

@xfthhxk xfthhxk mentioned this pull request Oct 2, 2018
Open
@mikeananev
Copy link

Check our fork: https://github.com/mikeananev/cambada

@luchiniatwork
Copy link
Owner

Would #17 fix this one?

@luchiniatwork luchiniatwork added the duplicate This issue or pull request already exists label Nov 14, 2019
@xfthhxk
Copy link
Contributor Author

xfthhxk commented Dec 14, 2019

@luchiniatwork No this PR and #17 are addressing different issues.

@xfthhxk xfthhxk closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xfthhxk @mikeananev @luchiniatwork